further clean video crates #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves a bunch of bitio ops into its own create and removes the need for a bytewriter type.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 49.99% 50.36% +0.37%
==========================================
Files 201 198 -3
Lines 16343 16238 -105
==========================================
+ Hits 8171 8179 +8
+ Misses 8172 8059 -113
... and 1 file with indirect coverage changes
|
lennartkloock
approved these changes
Jan 7, 2025
|
?brawl merge |
|
📌 Commit 6c10f3d has been approved and added to the merge queue. Requested by: @TroyKomodo Approved by: @lennartkloock |
|
🎉 Build successful! Approved by: @lennartkloock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up more video creates, implementing a better bit reader & writer. As well as removing other unused bytesio helpers.
Also cleanup AAC's code to better reflect the spec.